Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes and tests. #673

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Misc fixes and tests. #673

merged 6 commits into from
Nov 18, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 14, 2024

Description

  • Added GET and HEAD /{index}/_source/{id} returning 404.
  • Added tests for GET /{index}/_refresh.
  • Added tests for POST /{index}/_mget.
  • Fixed all refresh options to allow boolean and string.
  • Added tests for POST /{index}/_update/{id}.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Changes Analysis

Commit SHA: 0c8b3b8
Comparing To SHA: bf35601

API Changes

Summary

├─┬Paths
│ ├─┬/{index}/_bulk
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_bulk/stream
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_update/{id}
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/_bulk/stream
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/_reindex
│ │ └─┬POST
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/{index}/_create/{id}
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_delete_by_query
│ │ └─┬POST
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/_bulk
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_doc/{id}
│ │ ├─┬GET
│ │ │ └─┬Parameters
│ │ │   └─┬Schema
│ │ │     └──[🔀] $ref (32493:9)❌ 
│ │ ├─┬PUT
│ │ │ └──Parameters
│ │ ├─┬POST
│ │ │ └──Parameters
│ │ ├─┬DELETE
│ │ │ └──Parameters
│ │ └─┬HEAD
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/{index}/_source/{id}
│ │ ├─┬GET
│ │ │ ├─┬Parameters
│ │ │ │ └─┬Schema
│ │ │ │   └──[🔀] $ref (32493:9)❌ 
│ │ │ └─┬Responses
│ │ │   └──[➕] codes (28552:7)
│ │ └─┬HEAD
│ │   ├─┬Parameters
│ │   │ └─┬Schema
│ │   │   └──[🔀] $ref (32493:9)❌ 
│ │   └─┬Responses
│ │     └──[➕] codes (28206:7)
│ ├─┬/{index}/_mget
│ │ ├─┬GET
│ │ │ └─┬Parameters
│ │ │   └─┬Schema
│ │ │     └──[🔀] $ref (32493:9)❌ 
│ │ └─┬POST
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/_mget
│ │ ├─┬GET
│ │ │ └─┬Parameters
│ │ │   └─┬Schema
│ │ │     └──[🔀] $ref (32493:9)❌ 
│ │ └─┬POST
│ │   └─┬Parameters
│ │     └─┬Schema
│ │       └──[🔀] $ref (32493:9)❌ 
│ ├─┬/{index}/_doc
│ │ └─┬POST
│ │   └──Parameters
│ └─┬/{index}/_update_by_query
│   └─┬POST
│     └─┬Parameters
│       └─┬Schema
│         └──[🔀] $ref (32493:9)❌ 
└─┬Components
  ├──[➕] responses (28206:7)
  ├──[➕] responses (28552:7)
  └─┬_common___Refresh
    ├──[➖] enum (32480:11)❌ 
    ├──[➖] enum (32481:11)❌ 
    ├──[➖] enum (32482:11)❌ 
    ├──[➖] type (32478:13)❌ 
    ├──[➕] oneOf (32494:11)
    └──[➕] oneOf (32493:11)

Document Element Total Changes Breaking Changes
paths 13 11
components 8 4
  • BREAKING Changes: 15 out of 21
  • Modifications: 11
  • Removals: 4
  • Additions: 6
  • Breaking Removals: 4
  • Breaking Modifications: 11

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11893676849/artifacts/2201639107

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 42 42 0

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Spec Test Coverage Analysis

Total Tested
517 358 (69.25 %)

@dblock dblock changed the title Added GET and HEAD /{index}/_source/{id} returning 404 + more tests. Misc fixes and tests. Nov 14, 2024
@dblock dblock marked this pull request as ready for review November 14, 2024 20:07
@dblock
Copy link
Member Author

dblock commented Nov 18, 2024

@Xtansia @nhtruong please?

@Xtansia Xtansia merged commit 4c1ea37 into opensearch-project:main Nov 18, 2024
25 checks passed
@dblock dblock deleted the more-tests branch November 18, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants