-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tests for ML APIs (search and delete) #672
Conversation
Changes AnalysisCommit SHA: c7569ac API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11865305204/artifacts/2196583379 API Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, needs a bit of work, iterate to green.
- Fix validation/CI failures.
- Sign DCO,
git commit --amend -s
for existing commits.
Signed-off-by: Nathalie Jonathan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The types for many of these things are too broad, I noted some below, but do look for existing fields with the same name for everything and see how they are declared with a ref
.
Update CHANGELOG.
The test failure looks legit, probably needs a refresh or maybe something more.
|
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests are still failing.
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there!
Signed-off-by: Nathalie Jonathan <[email protected]>
Looks like more fields are missing, https://github.com/opensearch-project/ml-commons/blob/9c1b8a8c1e28ab8bdaf507cb71799c4809c3d8c6/plugin/src/test/resources/org/opensearch/ml/autoredeploy/ModelResult.json#L7. |
Signed-off-by: Nathalie Jonathan <[email protected]>
Spec Test Coverage Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing tests!
Description
Added missing tests for
GET /_plugins/_ml/models/_search
andDELETE /_plugins/_ml/tasks/{task_id}
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.