Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added _search with sort: direction. #658

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 7, 2024

Description

  • Added _search with sort: direction.
  • Added a test for search_after.

Issues Resolved

Closes #173.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock force-pushed the sort-and-search-after branch from 1c3c0e8 to b5d8a2c Compare November 7, 2024 16:08
@dblock dblock changed the title Added direction sort without order. Added _search with sort: direction. Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Changes Analysis

Commit SHA: b5d8a2c
Comparing To SHA: d170916

API Changes

Summary

└─┬Components
  ├──[➕] schemas (31088:7)
  └─┬_common___SortCombinations
    ├──[➕] oneOf (32506:7)
    └─┬ONEOF
      └──[🔀] $ref (31088:13)❌ 

Document Element Total Changes Breaking Changes
components 3 1
  • BREAKING Changes: 1 out of 3
  • Modifications: 1
  • Additions: 2
  • Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11726837940/artifacts/2158683531

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 35 35 0

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Spec Test Coverage Analysis

Total Tested
510 315 (61.76 %)

@nhtruong nhtruong merged commit e41257a into opensearch-project:main Nov 7, 2024
26 checks passed
@dblock dblock deleted the sort-and-search-after branch November 8, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] search_after parameter added to _search, _msearch specifications
2 participants