-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed one of the duplicate '/_nodes/{metric}' and '/_nodes/{node_id}' paths. #416
Conversation
Changes AnalysisCommit SHA: de7fd22 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9947904959/artifacts/1704051538 API Coverage
|
This will cause a breaking change in the clients. The clients accepts both
This is another quirk of OpenSearch API. I'm thinking |
tools/tests/linter/fixtures/folder_validators/namespaces/invalid_folder/dup_path_d.yaml
Show resolved
Hide resolved
…}' paths. Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
I made the change by introducing I am not sure we're doing the right thing by introducing parameter hints where we try to express that this parameter is actually 2 different possible types. As written in this PR the parameter is |
Signed-off-by: dblock <[email protected]>
We should update https://github.com/opensearch-project/opensearch-api-specification/blob/main/CLIENT_GENERATOR_GUIDE.md to alert devs about this edge case as well. |
Co-authored-by: Thomas Farr <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: dblock <[email protected]>
Done, d4f3a55. |
Signed-off-by: dblock <[email protected]>
Description
Was trying to load the spec with the Ruby openapi3_parser and it failed with this error.
Now properly detecting dups.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.