-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run integration tests against OpenSearch 2.16. #409
Conversation
Changes AnalysisCommit SHA: 8b26266 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9896580766/artifacts/1692313234 API Coverage
|
f7178b1
to
cdcbab8
Compare
26260ee
to
5ba175e
Compare
matrix: | ||
entry: | ||
- {version: 2.15.0, hub: 'opensearchproject'} | ||
- {version: 2.16.0, hub: 'opensearchstaging'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. My concern is whether we should test multiple versions of OS now when the test framework cant differentiate which features in the spec can be tested against which version of OS. Say if we add a new query param in 2.17 and update the spec accordingly, then all matrix entries before 2.17 will likely fail stories that test the affected endpoint.
Potential solution (in a different PR): Add min_cluster_version
and max_cluster_version
properties for test stories and the test framework will only test the story if the it's being tested against a valid cluster version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad you asked, I got better in #410.
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Description
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.