Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed query DSL match that supports a field name and value #405

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 11, 2024

Description

Fixed query DSL match that supports a field name and value.
Added reindex tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock changed the title Fix Match. Fixed query DSL match that supports a field name and value Jul 11, 2024
Copy link
Contributor

github-actions bot commented Jul 11, 2024

Changes Analysis

Commit SHA: 021e704
Comparing To SHA: 610b6b5

API Changes

Summary

└─┬Components
  └─┬_common.query_dsl:QueryContainer
    └─┬match
      └─┬Schema
        └──[🔀] $ref (35810:13)❌ 

Document Element Total Changes Breaking Changes
components 1 1
  • BREAKING Changes: 1 out of 1
  • Modifications: 1
  • Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9899129185/artifacts/1693019011

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock force-pushed the reindex branch 3 times, most recently from c3af67d to 17c2b98 Compare July 11, 2024 21:37
@@ -74,6 +74,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Fixed `_source` in `bulk` responses ([#375](https://github.com/opensearch-project/opensearch-api-specification/pull/375))
- Fixed `/{index}/_dangling` that can return `nodes` and `cluster_name` ([#391](https://github.com/opensearch-project/opensearch-api-specification/pull/391))
- Fixed `Metadata` schema ([#399](https://github.com/opensearch-project/opensearch-api-specification/pull/399))
- Fixed query DSL `match` that supports a field name and value ([#405](https://github.com/opensearch-project/opensearch-api-specification/pull/405))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually pick a random location in the change logs listing instead of the last entry to avoid merging conflict :)

tests/_core/reindex.yaml Outdated Show resolved Hide resolved
tests/_core/reindex.yaml Outdated Show resolved Hide resolved
nhtruong
nhtruong previously approved these changes Jul 11, 2024
@nhtruong nhtruong merged commit 667091c into opensearch-project:main Jul 11, 2024
12 checks passed
@dblock dblock deleted the reindex branch July 11, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants