Refactored AJV usages with an AJV wrapper that provides better error JSON validation messages. #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhtruong
requested review from
dblock,
harshavamsi,
sachetalva,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
Changes AnalysisCommit SHA: b1ba40c API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9895698061/artifacts/1692047754 API Coverage
|
dblock
requested changes
Jul 7, 2024
nhtruong
force-pushed
the
ajv_errors_parser
branch
from
14e38fd to
2f28575
Compare
nhtruong
changed the title
nhtruong
force-pushed
the
ajv_errors_parser
branch
from
2f28575 to
623cf5a
Compare
|
@dblock This is now ready for review |
dblock
previously approved these changes
Jul 10, 2024
- Wrapper for AJV to streamline Json validation logic. - Collapse multiple `required` errors into one - Collapse multiple `additionalProperties` and `unevaluatedProperties` errors into one, and print out which properties are prohibited. - Make `enum` errors print out the supported enum values. Signed-off-by: Theo Truong <[email protected]>
nhtruong
force-pushed
the
ajv_errors_parser
branch
from
623cf5a to
b1ba40c
Compare
dblock
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonSchemaValidator
requirederrors into oneadditionalPropertiesandunevaluatedPropertieserrors into one, and print out which properties are prohibited.enumerrors print out the supported enum values.Issues Resolved
closes #364
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.