Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage nits. #329

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Code coverage nits. #329

merged 2 commits into from
Jun 10, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 10, 2024 •
edited
Loading

Description

  1. We currently collect coverage from the tests themselves, which isn't a thing.
Screenshot 2024-06-10 at 2 43 57 PM
  1. Adjust coverage threshold to avoid false negatives such as in the last commit to HEAD.
Screenshot 2024-06-10 at 2 53 35 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock added the skip-changelog No need to update CHANGELOG. label Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024 •
edited
Loading

Changes Analysis

Commit SHA: dff80e6
Comparing To SHA: 362c90c

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9453941964/artifacts/1586779216

API Coverage

Before After Δ
Covered (%) 476 (46.62 %) 476 (46.62 %) 0 (0 %)
Uncovered (%) 545 (53.38 %) 545 (53.38 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock changed the title Only collect coverage information from tools/src. Code coverage nits. Jun 10, 2024
@nhtruong nhtruong merged commit ba3f5b2 into opensearch-project:main Jun 10, 2024
9 checks passed
@dblock dblock deleted the more-coverage branch June 11, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhtruong nhtruong nhtruong approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@Xtansia Xtansia Awaiting requested review from Xtansia Xtansia is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Tokesh Tokesh Awaiting requested review from Tokesh Tokesh is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

Assignees
No one assigned
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblock @nhtruong