Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging and generator output. #322

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 6, 2024

Description

  • Displays the word "ERROR" or "WARNING" when logging at various levels.
  • Adds logger.log that wraps console.log.
  • Adds tests for Logger.
  • Improves a warning message in the generator to be more useful.
  • Adds tests for merge and linter command line tools.

Note that console.error, console.warn and friends are all aliases of console.log, they don't do anything different.

Issues Resolved

Closes #285.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock added the skip-changelog No need to update CHANGELOG. label Jun 6, 2024
@dblock dblock force-pushed the generator-output branch from 0686093 to 233f089 Compare June 6, 2024 16:57
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Changes Analysis

Commit SHA: d14327c
Comparing To SHA: 3ad078c

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9405132747/artifacts/1576171242

API Coverage

Before After Δ
Covered (%) 476 (46.62 %) 476 (46.62 %) 0 (0 %)
Uncovered (%) 545 (53.38 %) 545 (53.38 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock force-pushed the generator-output branch from 233f089 to 9206e0a Compare June 6, 2024 17:15
@dblock dblock force-pushed the generator-output branch from 9206e0a to d14327c Compare June 6, 2024 17:17
@Xtansia Xtansia merged commit de9b666 into opensearch-project:main Jun 6, 2024
8 checks passed
@dblock dblock deleted the generator-output branch June 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add positive output to the generator
2 participants