Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The use of shared resource is an anti-pattern that ties together unrelated concepts. A simple example is of
ChapterReader
that is only needed byChapterEvaluator
. By introducing a shared resource we start treating the spec, reader and evaluator as singletons in a way that combines them in 1 place, creating unneeded interdependencies. The one thing we do need to pass around is the actual spec, which makes sense as all these classes use the spec in some way. I think the resulting code is a lot clearer (and much shorter, especially in tests where we don't need to pre-create anything).I also cleaned up some test befores/after's.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.