Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notifications API specs #169
Add notifications API specs #169
Changes from 28 commits
a1f2950
c68ed62
032e0b6
ae8cdab
980fe0b
2a75ce0
e04fb52
dce569a
8ade51b
281fc45
b49f32e
a9c0251
c2b29cb
a00a55c
2863919
491a033
5f46337
4e1beb9
50a91a7
4e8e629
2e697d9
1b2f47e
e78d0a8
09feb68
3f71d33
a8ed7b1
5e4374f
07c6d20
9fdf1cf
c38fdd3
487bf48
056d69b
d4699e1
bb53f39
b6b933f
08105e5
e6308b4
189417f
f8f0fdf
9261f13
3a17c5a
3d5f05e
68e6497
796cd09
84c7b51
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct schema, as the
slack
,sns
etc. should be at the same level asconfig_type
not within adetails
field.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit torn on this one. I think
notifications.create_channel_config
is more clear. But since this is the only kind of configs being manipulated in this plugin, it doesn't matter? 🤷 What do you think?