Mark keep_alive as time type and correct _shards field name
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
requested review from
dblock,
harshavamsi,
pgtgrly,
sachetalva,
nhtruong and
VachaShah
as code owners
VachaShah
reviewed
Oct 17, 2023
| @@ -37,6 +37,6 @@ structure CreatePit_Input with [CreatePit_QueryParams] { | |||
| @output | |||
| structure CreatePit_Output { | |||
| pit_id: String, | |||
| _shard: ShardStatistics, | |||
| _shards: ShardStatistics, | |||
There was a problem hiding this comment.
@Xtansia Does this change need regenerating whatever we generated for the python client?
There was a problem hiding this comment.
This is part of the response body, so won't have been used, just noticed it while writing bodies for .NET
VachaShah
approved these changes
Oct 17, 2023
|
@Xtansia Merge? |
|
@dblock Can you approve this PR? This repo requires 2 approving reviewers. |
nhtruong
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects the
keep_aliveparameter and_shardsresponse field of the PIT apis.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.