Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT 1.3] feat: enable windows and macos builds (#1108) #1328

Merged
merged 7 commits into from
Dec 6, 2022
Merged

[BACKPORT 1.3] feat: enable windows and macos builds (#1108) #1328

merged 7 commits into from
Dec 6, 2022

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Dec 6, 2022

(cherry picked from commit 363ccd4)
Signed-off-by: Derek Ho [email protected]

Description

[Describe what this change achieves]

Issues Resolved

#1305
#1324

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

derek-ho and others added 5 commits December 6, 2022 10:25
* fix: initial code to add windows support for opensearch-observability

Signed-off-by: Derek Ho <[email protected]>

* add build for windows in dashboards-observability

Signed-off-by: Derek Ho <[email protected]>

* change windows command and add windows build for UI modules

Signed-off-by: Derek Ho <[email protected]>

* try gradlew bat for windows

Signed-off-by: Derek Ho <[email protected]>

* try to exclude tests

Signed-off-by: Derek Ho <[email protected]>

* fix jacoco

Signed-off-by: Derek Ho <[email protected]>

* do for mac and change name

Signed-off-by: Derek Ho <[email protected]>

* try to run the tests for windows and mac

Signed-off-by: Derek Ho <[email protected]>

* try to add gitattributes file

Signed-off-by: Derek Ho <[email protected]>

* add formatting rule

Signed-off-by: Derek Ho <[email protected]>

* try to enable both

Signed-off-by: Derek Ho <[email protected]>

* try to add git config to fix

Signed-off-by: Derek Ho <[email protected]>

* autocrlf false for windwos and remove comments

Signed-off-by: Derek Ho <[email protected]>

* comment out bwc tests,

Signed-off-by: Derek Ho <[email protected]>

* add line

Signed-off-by: Derek Ho <[email protected]>

* fix up using matrix and fix test

Signed-off-by: Derek Ho <[email protected]>

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 363ccd4)
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho changed the title feat: enable windows and macos builds (#1108) [BACKPORT 1.3] feat: enable windows and macos builds (#1108) Dec 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #1328 (439702c) into 1.3 (bd9956f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.3    #1328   +/-   ##
=========================================
  Coverage     54.87%   54.87%           
  Complexity      283      283           
=========================================
  Files           244      244           
  Lines          7747     7750    +3     
  Branches       1551     1551           
=========================================
+ Hits           4251     4253    +2     
- Misses         3326     3327    +1     
  Partials        170      170           
Flag Coverage Δ
dashboards-observability 46.51% <ø> (ø)
opensearch-observability 76.55% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vability/public/components/explorer/no_results.tsx 100.00% <ø> (ø)
...ensearch/observability/index/ObservabilityIndex.kt 56.14% <0.00%> (-1.35%) ⬇️
...ch/observability/index/ObservabilityQueryHelper.kt 57.40% <0.00%> (+1.04%) ⬆️
...ensearch/observability/model/SavedVisualization.kt 96.34% <0.00%> (+2.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho merged commit 33d7f35 into opensearch-project:1.3 Dec 6, 2022
derek-ho added a commit that referenced this pull request Dec 22, 2022
* feat: enable windows and macos builds (#1108)

* fix: initial code to add windows support for opensearch-observability

Signed-off-by: Derek Ho <[email protected]>

* add build for windows in dashboards-observability

Signed-off-by: Derek Ho <[email protected]>

* change windows command and add windows build for UI modules

Signed-off-by: Derek Ho <[email protected]>

* try gradlew bat for windows

Signed-off-by: Derek Ho <[email protected]>

* try to exclude tests

Signed-off-by: Derek Ho <[email protected]>

* fix jacoco

Signed-off-by: Derek Ho <[email protected]>

* do for mac and change name

Signed-off-by: Derek Ho <[email protected]>

* try to run the tests for windows and mac

Signed-off-by: Derek Ho <[email protected]>

* try to add gitattributes file

Signed-off-by: Derek Ho <[email protected]>

* add formatting rule

Signed-off-by: Derek Ho <[email protected]>

* try to enable both

Signed-off-by: Derek Ho <[email protected]>

* try to add git config to fix

Signed-off-by: Derek Ho <[email protected]>

* autocrlf false for windwos and remove comments

Signed-off-by: Derek Ho <[email protected]>

* comment out bwc tests,

Signed-off-by: Derek Ho <[email protected]>

* add line

Signed-off-by: Derek Ho <[email protected]>

* fix up using matrix and fix test

Signed-off-by: Derek Ho <[email protected]>

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 0e65c32)
Signed-off-by: Derek Ho <[email protected]>

* remove java 17

Signed-off-by: Derek Ho <[email protected]>

* remove -d for windows

Signed-off-by: Derek Ho <[email protected]>

* Update .github/workflows/dashboards-observability-test-and-build-workflow.yml

Signed-off-by: Derek Ho <[email protected]>

* fix fail fast

Signed-off-by: Derek Ho <[email protected]>

* try to do fix step for mac

Signed-off-by: Derek Ho <[email protected]>

* remove mac

Signed-off-by: Derek Ho <[email protected]>

Signed-off-by: Derek Ho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants