-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACKPORT 1.3] feat: enable windows and macos builds (#1108) #1328
Merged
derek-ho
merged 7 commits into
opensearch-project:1.3
from
derek-ho:backport/backport-1108-to-1.3
Dec 6, 2022
Merged
[BACKPORT 1.3] feat: enable windows and macos builds (#1108) #1328
derek-ho
merged 7 commits into
opensearch-project:1.3
from
derek-ho:backport/backport-1108-to-1.3
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: initial code to add windows support for opensearch-observability Signed-off-by: Derek Ho <[email protected]> * add build for windows in dashboards-observability Signed-off-by: Derek Ho <[email protected]> * change windows command and add windows build for UI modules Signed-off-by: Derek Ho <[email protected]> * try gradlew bat for windows Signed-off-by: Derek Ho <[email protected]> * try to exclude tests Signed-off-by: Derek Ho <[email protected]> * fix jacoco Signed-off-by: Derek Ho <[email protected]> * do for mac and change name Signed-off-by: Derek Ho <[email protected]> * try to run the tests for windows and mac Signed-off-by: Derek Ho <[email protected]> * try to add gitattributes file Signed-off-by: Derek Ho <[email protected]> * add formatting rule Signed-off-by: Derek Ho <[email protected]> * try to enable both Signed-off-by: Derek Ho <[email protected]> * try to add git config to fix Signed-off-by: Derek Ho <[email protected]> * autocrlf false for windwos and remove comments Signed-off-by: Derek Ho <[email protected]> * comment out bwc tests, Signed-off-by: Derek Ho <[email protected]> * add line Signed-off-by: Derek Ho <[email protected]> * fix up using matrix and fix test Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 363ccd4) Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
…flow.yml Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
derek-ho
changed the title
feat: enable windows and macos builds (#1108)
[BACKPORT 1.3] feat: enable windows and macos builds (#1108)
Dec 6, 2022
Codecov Report
@@ Coverage Diff @@
## 1.3 #1328 +/- ##
=========================================
Coverage 54.87% 54.87%
Complexity 283 283
=========================================
Files 244 244
Lines 7747 7750 +3
Branches 1551 1551
=========================================
+ Hits 4251 4253 +2
- Misses 3326 3327 +1
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
kavithacm
approved these changes
Dec 6, 2022
sejli
approved these changes
Dec 6, 2022
derek-ho
added a commit
that referenced
this pull request
Dec 22, 2022
* feat: enable windows and macos builds (#1108) * fix: initial code to add windows support for opensearch-observability Signed-off-by: Derek Ho <[email protected]> * add build for windows in dashboards-observability Signed-off-by: Derek Ho <[email protected]> * change windows command and add windows build for UI modules Signed-off-by: Derek Ho <[email protected]> * try gradlew bat for windows Signed-off-by: Derek Ho <[email protected]> * try to exclude tests Signed-off-by: Derek Ho <[email protected]> * fix jacoco Signed-off-by: Derek Ho <[email protected]> * do for mac and change name Signed-off-by: Derek Ho <[email protected]> * try to run the tests for windows and mac Signed-off-by: Derek Ho <[email protected]> * try to add gitattributes file Signed-off-by: Derek Ho <[email protected]> * add formatting rule Signed-off-by: Derek Ho <[email protected]> * try to enable both Signed-off-by: Derek Ho <[email protected]> * try to add git config to fix Signed-off-by: Derek Ho <[email protected]> * autocrlf false for windwos and remove comments Signed-off-by: Derek Ho <[email protected]> * comment out bwc tests, Signed-off-by: Derek Ho <[email protected]> * add line Signed-off-by: Derek Ho <[email protected]> * fix up using matrix and fix test Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 0e65c32) Signed-off-by: Derek Ho <[email protected]> * remove java 17 Signed-off-by: Derek Ho <[email protected]> * remove -d for windows Signed-off-by: Derek Ho <[email protected]> * Update .github/workflows/dashboards-observability-test-and-build-workflow.yml Signed-off-by: Derek Ho <[email protected]> * fix fail fast Signed-off-by: Derek Ho <[email protected]> * try to do fix step for mac Signed-off-by: Derek Ho <[email protected]> * remove mac Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Derek Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 363ccd4)
Signed-off-by: Derek Ho [email protected]
Description
[Describe what this change achieves]
Issues Resolved
#1305
#1324
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.