[chore]: bump developer guide java version #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Menendez <[email protected]>
IanMenendez
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es,
vibrantvarun and
zhichao-aws
as code owners
5 tasks
|
Can you also update the section title and description? |
Signed-off-by: Ian Menendez <[email protected]>
|
Missed that. Need some rest haha |
|
Thank you. Since 2.x can still run on JDK 11 and 17, there is no need to backport this PR to 2.x. |
martin-gaievski
approved these changes
Sep 16, 2024
|
We can merge this one, CI is failing for some unrelated reason. @vibrantvarun can you please review? |
|
Pinging @zane-neo and @zhichao-aws for review |
martin-gaievski
pushed a commit
to Johnsonisaacn/neural-search
that referenced
this pull request
Oct 11, 2024
* chore: bump guide java version Signed-off-by: Ian Menendez <[email protected]> * chore: java 21 on title and other parts Signed-off-by: Ian Menendez <[email protected]> --------- Signed-off-by: Ian Menendez <[email protected]>
zhichao-aws
pushed a commit
to zhichao-aws/neural-search
that referenced
this pull request
Jan 6, 2025
* chore: bump guide java version Signed-off-by: Ian Menendez <[email protected]> * chore: java 21 on title and other parts Signed-off-by: Ian Menendez <[email protected]> --------- Signed-off-by: Ian Menendez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumped Java version in developer guide since it was outdated
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.