Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation errors after recent changes in ml-commons #285

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Sep 5, 2023

Description

After recent changes in ml-commons we need to make few changes:

  • update tests to generate new model group on every test, same model group name is not allowed by ml-commons
  • update test classes to support constructor of ModelTensor in latest ml-commons

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski force-pushed the fixed-after-changes-in-main-and-mlcomons branch from d7dc039 to fd65ee4 Compare September 7, 2023 22:24
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #285 (8490254) into main (685d5d6) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #285   +/-   ##
=========================================
  Coverage     85.77%   85.77%           
  Complexity      376      376           
=========================================
  Files            30       30           
  Lines          1104     1104           
  Branches        168      168           
=========================================
  Hits            947      947           
  Misses           83       83           
  Partials         74       74           

📢 Have feedback on the report? Share it here.

@martin-gaievski martin-gaievski changed the title Fixed compilation errors after recent changes in core and ml-commons Fixed compilation errors after recent changes in ml-commons Sep 7, 2023
@martin-gaievski martin-gaievski merged commit 5bf36ed into opensearch-project:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Add support for new versions of OpenSearch/Dashboards from upstream skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants