Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of new k-NN query parameter, expand_nested #1013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support of new k-NN query parameter, expand_nested #1013

wants to merge 1 commit into from

Conversation

bzhangam
Copy link

Description

Support new knn query parameter expand_nested_docs.

Related Issues

Resolves #1008

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

yizheliu-amazon
yizheliu-amazon reviewed Dec 14, 2024
View reviewed changes
Copy link

@yizheliu-amazon yizheliu-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

CHANGELOG.md Outdated Show resolved Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralQueryBuilder.java Outdated Show resolved Hide resolved
@heemin32 heemin32 added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Dec 16, 2024
@bzhangam bzhangam changed the title [FEATURE]Support of new k-NN query parameter, expand_nested_docs #1008 [FEATURE]Support of new k-NN query parameter, expand_nested_docs Dec 16, 2024
@heemin32
Copy link
Collaborator

Please resolve the changelog conflict

@heemin32
Copy link
Collaborator

heemin32 commented Dec 16, 2024 •
edited
Loading

  1. Remove [FEATURE] from PR title.
  2. Keep the CHANGELOG entry to be same as PR title.

@bzhangam bzhangam closed this Dec 16, 2024
@bzhangam bzhangam changed the title [FEATURE]Support of new k-NN query parameter, expand_nested_docs Support of new k-NN query parameter, expand_nested Dec 16, 2024
@bzhangam bzhangam reopened this Dec 16, 2024
@martin-gaievski
Copy link
Member

Overall code looks good to me.
One additional point - I think we have reached the point of NeuralQueryBuild having that always growing constructor of gazillion fields. Can you please add a builder class similar to one in KNNQueryBuilder, or log a new issue for this repo if the effort is beyond your bandwidth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yizheliu-amazon yizheliu-amazon yizheliu-amazon left review comments

@heemin32 heemin32 heemin32 approved these changes

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@vibrantvarun vibrantvarun Awaiting requested review from vibrantvarun vibrantvarun is a code owner

@zhichao-aws zhichao-aws Awaiting requested review from zhichao-aws zhichao-aws is a code owner

@yuye-aws yuye-aws Awaiting requested review from yuye-aws yuye-aws is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]Support of new k-NN query parameter, expand_nested_docs
4 participants
@bzhangam @heemin32 @martin-gaievski @yizheliu-amazon