Support the latest versions of Logstash and the AWS SDK for Ruby. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the account_id configuration to the AWSIAMCredential struct to work with the latest versions of the AWS SDK for Ruby. Test against the latest versions of Logstash during the integration testing to also test against these versions of the AWS SDK. Resolves opensearch-project#258 Signed-off-by: David Venable <[email protected]>
Signed-off-by: David Venable <[email protected]>
dblock
approved these changes
Oct 17, 2024
|
I assume CI reproduces this without a fix now? If so merge at will, cut a release. |
|
I ran this first to reproduce locally: And the tests failed with the same error from the #258 issue. This PR uses that same version in the |
|
Thanks so much for fixing this @dlvenable! |
|
confirmed, the plugin works on my local env. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
account_idconfiguration to theAWSIAMCredentialstruct to work with the latest versions of the AWS SDK for Ruby. Leaving this asnilshould be sufficient because we do not use account-based endpoints.Test against the latest versions of Logstash during the integration testing to also test against these versions of the AWS SDK. For Logstash 7, this is 7.17.24. For Logstash 8, this is 8.15.3.
The GitHub Actions runners now have
docker composeinstead ofdocker-compose, so I also updated all those references.Issues Resolved
Resolves #258
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.