Removing micro-benchmarks module due to JMH using GPL #2337
+0
−393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navneet Verma <[email protected]>
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
navneet1v
added
Infrastructure
ryanbogan
approved these changes
Dec 16, 2024
martin-gaievski
approved these changes
Dec 16, 2024
naveentatikonda
approved these changes
Dec 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 443c3d5)
navneet1v
added a commit
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 443c3d5) Co-authored-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing micro-benchmarks module due to JMH using GPL. Even though this module is not added in the main distribution, we still need to figure out what exactly we want to do for micro-benchmarks. I can see Lucene and Opensearch is using the JMH for micro-benchmarking with Apache V2 License. Ref: #2291 (comment)
But just to be on safer side, I am removing this module for now till we figure out a better way to integrate with JMH.
Related Issues
Ref: #2291
Check List
New functionality includes testing.New functionality has been documented.API changes companion pull request created.--signoff.Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.