Update knn index default to always do approximate search in test #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
force-pushed
the
update-default-index-settings-test
branch
2 times, most recently
from
cf1deca to
5701675
Compare
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
navneet1v
previously approved these changes
Dec 13, 2024
|
There might be test cases which use custom setting instead of default setting. We need to update those cases as well. |
like what? Can you share the test that you are referring to? |
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
update-default-index-settings-test
branch
from
850ddba to
691810a
Compare
Signed-off-by: Vijayan Balasubramanian <[email protected]>
navneet1v
reviewed
Dec 17, 2024
Comment on lines
+109
to
+112
| Settings settings = Settings.builder() | ||
| .put("index.knn", true) | ||
| .put(KNNSettings.KNN_ALGO_PARAM_EF_SEARCH, 512) | ||
| .put(KNNSettings.INDEX_KNN_ADVANCED_APPROXIMATE_THRESHOLD, 0) |
There was a problem hiding this comment.
for cases like this I think we should just move the code to use getDefaultIndexSettings so that in future we don't need to make the changes.
navneet1v
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update knn index default to always do approximate search in test cases
Related Issues
Resolves #2329
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.