Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BWC tests for Lucene Engine #2313

Merged
merged 9 commits into from
Dec 16, 2024

Conversation

buddharajusahil
Copy link
Contributor

@buddharajusahil buddharajusahil commented Dec 7, 2024

Description

This change adds bwc tests for Lucene Engine, as there had not been any previously.

Related Issues

Resolves #1725

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • [N/A] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sahil Buddharaju added 5 commits December 6, 2024 16:45
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
@navneet1v
Copy link
Collaborator

@buddharajusahil please fix the failing CIs

Signed-off-by: Sahil Buddharaju <[email protected]>
@naveentatikonda naveentatikonda changed the title Lucene bwc tests (Addresses issue #1725) Add BWC tests for Lucene Engine Dec 10, 2024
Sahil Buddharaju added 3 commits December 12, 2024 10:19
Signed-off-by: Sahil Buddharaju <[email protected]>
Signed-off-by: Sahil Buddharaju <[email protected]>
@jmazanec15 jmazanec15 merged commit f50a8f5 into opensearch-project:main Dec 16, 2024
25 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2313-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f50a8f5383935435784711c124715efcff871b48
# Push it to GitHub
git push --set-upstream origin backport/backport-2313-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2313-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BWC] No Indexing and Search BWC tests added for Lucene Engine
4 participants