-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable script score to work with model based indices #1649
Enable script score to work with model based indices #1649
Conversation
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
src/main/java/org/opensearch/knn/plugin/script/KNNScoringSpaceUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/plugin/script/KNNScoringSpaceUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/plugin/script/KNNScoringSpaceUtil.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/knn/plugin/script/KNNScoringSpaceUtilTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
@ryanbogan I don't see the IT for this change. Can you please add an IT for this change |
Signed-off-by: Ryan Bogan <[email protected]>
708ef61
Signed-off-by: Ryan Bogan <[email protected]>
I'm going to remove the * import in the integration test shortly |
Signed-off-by: Ryan Bogan <[email protected]>
BWC failures are not related to this PR, and were passing earlier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall code looks good to me. Let ensure all gh actions are successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thx. Link checker is failing, but that's not related to changes in this PR
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1649-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e608d2de4be4c86b0b45c6211baef91a9c46af22
# Push it to GitHub
git push --set-upstream origin backport/backport-1649-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Description
Previously, an exception would be thrown when attempting to use script score with a model-based index. Since the expected dimensions for a model-based index field are set to -1, there would be a mismatch between the actual dimension of the float array and the expected dimension. This PR retrieves the expected dimensions from the model metadata for model-based indices, thus enabling script score to work as intended.
Issues Resolved
#1554
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.