Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable script score to work with model based indices #1649

Merged
merged 7 commits into from
Apr 29, 2024

Conversation

ryanbogan
Copy link
Member

@ryanbogan ryanbogan commented Apr 23, 2024

Description

Previously, an exception would be thrown when attempting to use script score with a model-based index. Since the expected dimensions for a model-based index field are set to -1, there would be a mismatch between the actual dimension of the float array and the expected dimension. This PR retrieves the expected dimensions from the model metadata for model-based indices, thus enabling script score to work as intended.

Issues Resolved

#1554

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Bogan <[email protected]>
jmazanec15
jmazanec15 previously approved these changes Apr 23, 2024
@navneet1v
Copy link
Collaborator

@ryanbogan I don't see the IT for this change. Can you please add an IT for this change

Signed-off-by: Ryan Bogan <[email protected]>
@ryanbogan
Copy link
Member Author

I'm going to remove the * import in the integration test shortly

Signed-off-by: Ryan Bogan <[email protected]>
@ryanbogan
Copy link
Member Author

BWC failures are not related to this PR, and were passing earlier

Copy link
Collaborator

@navneet1v navneet1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code looks good to me. Let ensure all gh actions are successful.

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thx. Link checker is failing, but that's not related to changes in this PR

@ryanbogan ryanbogan merged commit e608d2d into opensearch-project:main Apr 29, 2024
55 of 56 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1649-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e608d2de4be4c86b0b45c6211baef91a9c46af22
# Push it to GitHub
git push --set-upstream origin backport/backport-1649-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1649-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants