Rename radial search parameters score and distance to min_score and max_distance #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
martin-gaievski and
ryanbogan
as code owners
junqiu-lei
force-pushed
the
rename-radial-search
branch
from
19bbca6 to
8a1df97
Compare
junqiu-lei
force-pushed
the
feature/radius-search
branch
from
149350d to
5e9fc7d
Compare
junqiu-lei
force-pushed
the
rename-radial-search
branch
from
8a1df97 to
f7e72c9
Compare
…ax_distance Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
rename-radial-search
branch
from
f7e72c9 to
26db7f1
Compare
navneet1v
reviewed
Apr 12, 2024
src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java
Outdated
Show resolved
Hide resolved
navneet1v
reviewed
Apr 12, 2024
src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Junqiu Lei <[email protected]>
navneet1v
approved these changes
Apr 12, 2024
naveentatikonda
approved these changes
Apr 12, 2024
junqiu-lei
merged commit 089b360
into
opensearch-project:feature/radius-search
45 of 50 checks passed
junqiu-lei
added a commit
to junqiu-lei/k-NN
that referenced
this pull request
Apr 17, 2024
…ax_distance (opensearch-project#1609) * Rename radial search parameters score and distance to min_score and max_distance Signed-off-by: Junqiu Lei <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename radial search parameters score and distance to min_score and max_distance
Issues Resolved
Part of #814
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.