Update k-NN build artifact script to enable SIMD on ARM for Faiss #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
added
Infrastructure
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
|
@peterzhuamazon Can you pls review this PR ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1543 +/- ##
============================================
+ Coverage 85.08% 85.17% +0.09%
Complexity 1299 1299
============================================
Files 171 171
Lines 5295 5295
Branches 506 506
============================================
+ Hits 4505 4510 +5
+ Misses 577 572 -5
Partials 213 213 ☔ View full report in Codecov by Sentry. |
jmazanec15
approved these changes
Mar 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
) (cherry picked from commit 2959d06)
naveentatikonda
added a commit
that referenced
this pull request
Mar 15, 2024
) (cherry picked from commit 2959d06) Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
added a commit
that referenced
this pull request
Mar 15, 2024
) (#1544) (cherry picked from commit 2959d06) Signed-off-by: Naveen Tatikonda <[email protected]> Co-authored-by: Naveen Tatikonda <[email protected]>
72 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update k-NN build artifact script to enable SIMD on ARM for Faiss because CentOS is supporting gcc version 9.3.x
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.