Fix AppSec Findings CWE-22 and CWE-476 #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
============================================
- Coverage 85.11% 85.09% -0.02%
- Complexity 1281 1291 +10
============================================
Files 168 169 +1
Lines 5232 5260 +28
Branches 495 499 +4
============================================
+ Hits 4453 4476 +23
- Misses 572 573 +1
- Partials 207 211 +4 ☔ View full report in Codecov by Sentry. |
jmazanec15
reviewed
Mar 12, 2024
qa/rolling-upgrade/src/test/java/org/opensearch/knn/bwc/AbstractRollingUpgradeTestCase.java
Outdated
Show resolved
Hide resolved
naveentatikonda
force-pushed
the
fix_appsec_findings
branch
from
560327c to
3cd0b42
Compare
naveentatikonda
force-pushed
the
fix_appsec_findings
branch
from
3cd0b42 to
b86aa7f
Compare
jmazanec15
reviewed
Mar 13, 2024
naveentatikonda
force-pushed
the
fix_appsec_findings
branch
from
b86aa7f to
a337eeb
Compare
VijayanB
reviewed
Mar 13, 2024
VijayanB
reviewed
Mar 13, 2024
VijayanB
reviewed
Mar 13, 2024
VijayanB
reviewed
Mar 13, 2024
naveentatikonda
force-pushed
the
fix_appsec_findings
branch
from
a337eeb to
367a2b6
Compare
Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
force-pushed
the
fix_appsec_findings
branch
from
367a2b6 to
dee5cca
Compare
jmazanec15
approved these changes
Mar 14, 2024
naveentatikonda
changed the title
VijayanB
approved these changes
Mar 14, 2024
naveentatikonda
merged commit bfcf7dc
into
opensearch-project:main
52 of 53 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
… Dereference) (#1528) Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit bfcf7dc)
naveentatikonda
added a commit
that referenced
this pull request
Mar 14, 2024
… Dereference) (#1528) (#1539) Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit bfcf7dc) Co-authored-by: Naveen Tatikonda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the following AppSec findings:
CWE-22 is used to identify an "Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')"
weakness.
CWE-476 is used to identify a "NULL Pointer Dereference" weakness.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.