Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Range Validation for SQFP16 #1493

Add BWC Tests

e84d598
Select commit
Loading
Failed to load commit list.
Merged

Add Range Validation for SQFP16 #1493

Add BWC Tests
e84d598
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 14, 2024 in 0s

84.99% (target 70.00%)

View this Pull Request on Codecov

84.99% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 71.42857% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 84.99%. Comparing base (7a144b8) to head (e84d598).

Files Patch % Lines
...nsearch/knn/index/mapper/KNNVectorFieldMapper.java 72.72% 6 Missing and 3 partials ⚠️
.../main/java/org/opensearch/knn/index/Parameter.java 36.36% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             feature/faiss_sqfp16    #1493      +/-   ##
==========================================================
- Coverage                   85.14%   84.99%   -0.16%     
- Complexity                   1281     1295      +14     
==========================================================
  Files                         168      168              
  Lines                        5232     5286      +54     
  Branches                      495      510      +15     
==========================================================
+ Hits                         4455     4493      +38     
- Misses                        570      580      +10     
- Partials                      207      213       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.