Integrate MDS client to ISM #711
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #711 +/- ##
==========================================
- Coverage 63.37% 63.16% -0.21%
==========================================
Files 341 345 +4
Lines 11545 11591 +46
Branches 2108 2111 +3
==========================================
+ Hits 7317 7322 +5
- Misses 3654 3695 +41
Partials 574 574 |
xluo-aws
reviewed
Apr 23, 2023
xluo-aws
reviewed
Apr 23, 2023
| }, | ||
| }, | ||
| method: "POST", | ||
| extendClient({ |
There was a problem hiding this comment.
I saw the logic is moved to clusters/extend_client.ts, there is no much logic left in the ismPlugin.ts file, what's the benefit of break it to two files?
There was a problem hiding this comment.
We need to extend the legacyClient and OpenSearchClient(in MDS case) but the context is different when constructing so we have to move all the ism.xxx = ca(xxx) code into a separate function to reuse the extend logic.
xluo-aws
reviewed
Apr 23, 2023
|
|
||
| export const getClientSupportMDS = (props: IGetClientProps) => { | ||
| const originalAsScoped = props.client.asScoped; | ||
| const handler: IContextProvider<RequestHandler<unknown, unknown, unknown>, "core"> = ( |
SuZhou-Joe
commented
Apr 27, 2023
server/plugin.ts
Outdated
| core, | ||
| client: legacyClient, | ||
| getDataSourceId() { | ||
| return "3e2ff6a0-de64-11ed-b697-57f5dd34beb6"; |
There was a problem hiding this comment.
Recommendation: Use a request level params to get data source id, make it stateless.
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
SuZhou-Joe
force-pushed
the
feature/mds-client-with-ism
branch
from
92302f8 to
f93a406
Compare
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.