Allow security plugin's install_demo_configuration to write to opensearch.yml #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h.yml Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
cwperks
changed the title
|
Closing this as duplicate of #618 |
Signed-off-by: Craig Perkins <[email protected]>
|
Re-opened temporarily to verify CI checks. |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR comments out the demo configuration values for the security plugin in
values.yamlof the opensearch chart. When a pod is spun up, it runs theinstall_demo_configurationscript which will write these values intoopensearch.ymlso the helm chart does not need to explicitly include these. Leaving these values in as a comment so users of the chart know what to replace when configuring security.Tested by modifying the
values.yamlof the opensearch chart and ensuring a cluster boots up properly after running:Issues Resolved
Resolves: opensearch-project/security#4923
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.