-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename storageClass to storageClassName based in docs and comments #553
base: main
Are you sure you want to change the base?
fix: rename storageClass to storageClassName based in docs and comments #553
Conversation
this should be fixed |
Adding @TheAlgo to take a look since this looks like a rollover when we migrate from devops repo to helm-charts repo. cc: @prudhvigodithi Hi @afzouni have you tested this change and confirm it failed before your change, but succeed after you apply the fix? |
Hi @peterzhuamazon, yes, I tested it. Before the change, it failed, but after setting the |
Adding @prudhvigodithi to take a look, I am ok with this one. Thanks. |
…lass-into-storageClassName
Signed-off-by: Peter Zhu <[email protected]>
Updated changelog and charts version and rebased on main. Thanks. |
Adding @prudhvigodithi and @TheAlgo to take a look as I am fine with this change. I will update the version and changelog once we approve. Thanks. |
Thanks @afzouni LGTM. Question is what happens for users who had |
Thanks @prudhvigodithi , pending @afzouni responses before I give my approval and change version. |
Thanks @prudhvigodithi and @prudhvigodithi, Sorry, I’m a bit confused, What exactly do you need me to response to? |
@afzouni please check this? |
Sure, and sorry for my delay. If users previously defined helm-charts/charts/opensearch/templates/statefulset.yaml Lines 46 to 52 in a1c5b8f
However, after merging this pull request, if they pull the latest version of the chart and reapply it, the P.S: As an idea, instead of changing |
Description
In the values.yaml and README.md, it mentions defining
storageClassName
to use a custom storageClassName. However, the variable in statefulset.yaml usesstorageClass
instead. This pull request changesstorageClass
tostorageClassName
to ensure consistency and proper functionality.Issues Resolved
storageClassName
.Check List
For any changes to files within Helm chart directories:
CHANGELOG.md
updated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.