Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Breaking Changes for 2.0 #602

Merged
merged 6 commits into from
May 26, 2022
Merged

Add Breaking Changes for 2.0 #602

merged 6 commits into from
May 26, 2022

Conversation

Naarcha-AWS
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS commented May 24, 2022

Fixes #473

Signed-off-by: Naarcha-AWS [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS marked this pull request as ready for review May 24, 2022 15:52
@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner May 24, 2022 15:52
@Naarcha-AWS Naarcha-AWS self-assigned this May 24, 2022
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress v2.0.0 labels May 24, 2022
Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

breaking-changes.md Outdated Show resolved Hide resolved
breaking-changes.md Outdated Show resolved Hide resolved
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS requested review from keithhc2 and hdhalter May 24, 2022 16:29
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my changes and let me know if you have any questions. Thanks!

breaking-changes.md Outdated Show resolved Hide resolved
breaking-changes.md Outdated Show resolved Hide resolved

In order for OpenSearch to include more inclusive naming conventions, we've replaced the following terms in our code with a more inclusive term:

- "White list" is now "Allow list".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"whitelist" should be one word. Lowercase "allow list".

breaking-changes.md Outdated Show resolved Hide resolved

- "White list" is now "Allow list".
- "Black list is now "White list".
- "Master" is now "Cluster Manager".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase "cluster manager". Confirm that "master" is the full term "cluster manager" is replacing.

breaking-changes.md Outdated Show resolved Hide resolved
breaking-changes.md Outdated Show resolved Hide resolved
breaking-changes.md Outdated Show resolved Hide resolved
breaking-changes.md Outdated Show resolved Hide resolved
@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label May 24, 2022
@Naarcha-AWS Naarcha-AWS added the 6 - Done but waiting to merge PR: The work is done and ready to merge label May 26, 2022
@Naarcha-AWS Naarcha-AWS merged commit 6c75514 into main May 26, 2022
@Naarcha-AWS Naarcha-AWS deleted the 2.0-breaking-changes branch September 14, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Make a breaking changes list for v2.0.0
5 participants