-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Breaking Changes for 2.0 #602
Conversation
Signed-off-by: Naarcha-AWS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my changes and let me know if you have any questions. Thanks!
breaking-changes.md
Outdated
|
||
In order for OpenSearch to include more inclusive naming conventions, we've replaced the following terms in our code with a more inclusive term: | ||
|
||
- "White list" is now "Allow list". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"whitelist" should be one word. Lowercase "allow list".
breaking-changes.md
Outdated
|
||
- "White list" is now "Allow list". | ||
- "Black list is now "White list". | ||
- "Master" is now "Cluster Manager". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowercase "cluster manager". Confirm that "master" is the full term "cluster manager" is replacing.
Signed-off-by: Naarcha-AWS <[email protected]>
Fixes #473
Signed-off-by: Naarcha-AWS [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.