Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Jay Deng <[email protected]>
  • Loading branch information
jed326 and kolchfa-aws authored Feb 6, 2024
1 parent 9df5741 commit 1fcb205
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions _search-plugins/concurrent-segment-search.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ The following aggregations do not support the concurrent search model. If a sear
- Parent aggregations on [join]({{site.url}}{{site.baseurl}}/field-types/supported-field-types/join/) fields
- Sampler and Diversified Sampler aggregations.

## Things To Know
## Things to know

### The `terminate_after` search parameter

Check failure on line 159 in _search-plugins/concurrent-segment-search.md

View workflow job for this annotation

GitHub Actions / style-job

[vale] reported by reviewdog 🐶 [OpenSearch.StackedHeadings] Do not stack headings. Insert an introductory sentence between headings. Raw Output: {"message": "[OpenSearch.StackedHeadings] Do not stack headings. Insert an introductory sentence between headings.", "location": {"path": "_search-plugins/concurrent-segment-search.md", "range": {"start": {"line": 159, "column": 1}}}, "severity": "ERROR"}

Expand All @@ -164,11 +164,11 @@ Typically, queries are used with smaller `terminate_after` values and thus compl

### Sorting

When performing sort operations there are optimizations from Lucene that allow for pruning entire segments which can greatly speed up the request. Whether or not these optimizations are able to kick in depends on both the segment layout as well as the query construction. For concurrent segment search, segments are grouped into segment slices, so in certain cases these sort optimizations may not be applicable to the segment slices. In these cases users may see an increase in query latency when performing sort operations.
When performing sort operations, optimizations from Lucene that allow for pruning entire segments can greatly speed up the request. Whether these optimizations are able to kick in depends on both the segment layout and the query construction. For concurrent segment search, segments are grouped into segment slices, so in certain cases these sort optimizations may not be applicable to the segment slices. In these cases, you may see an increase in query latency when performing sort operations.

### Terms Aggregations
### Terms aggregations

When performing concurrent segment search the `shard_size` parameter will be applied at the segment slice level. This may introduce additional document count error, which is correctly calculated by the `doc_count_error_upper_bound` response parameter for such cases.
When performing concurrent segment search, the `shard_size` parameter will be applied at the segment slice level. This may introduce additional document count error, which is correctly calculated by the `doc_count_error_upper_bound` response parameter for such cases.

## Developer information: AggregatorFactory changes

Expand Down

0 comments on commit 1fcb205

Please sign in to comment.