Made the BulkRetryStrategyTests less reliant on implementation specifics from OpenSearch #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom the the implementation of the bulk client in OpenSearch. This change works for both OpenSearch 1 and 2. Updated to use JUnit 5 as well, and some other refactoring. Signed-off-by: David Venable <[email protected]>
dinujoh
previously approved these changes
Apr 29, 2022
chenqi0805
previously approved these changes
Apr 29, 2022
|
|
||
| @Before | ||
| @BeforeEach | ||
| public void metricsInit() { | ||
| MetricsTestUtil.initMetrics(); |
There was a problem hiding this comment.
Suggest put it in the setUp instead of another @beforeeach method
There was a problem hiding this comment.
Thanks for the suggestion @chenqi0805 ! I pushed a change for it. Please re-review.
…omment. Signed-off-by: David Venable <[email protected]>
chenqi0805
approved these changes
Apr 29, 2022
dinujoh
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes are to help support using OpenSearch 2.0.0-RC1 (#1311) in Data Prepper.
DocWriteRequest.toString(). This change uses mocking to decouple that.I've tested this code locally when compiling both against OpenSearch 1.1.0 (current compile-time version) and 2.0.0-RC1.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.