Use smaller and compressed varients of buttons and form components #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
AMoo-Miki
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
|
We may need to update the snapshots |
derek-ho
previously approved these changes
Aug 2, 2024
Signed-off-by: Miki <[email protected]>
derek-ho
approved these changes
Aug 2, 2024
|
@AMoo-Miki should this be backported to 2.x? |
derek-ho
approved these changes
Aug 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…383) * Use EuiCompressedFormRow Signed-off-by: Miki <[email protected]> * Use EuiCompressedField* Signed-off-by: Miki <[email protected]> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <[email protected]> * Use EuiCompressedSwitch Signed-off-by: Miki <[email protected]> * Update snapshots Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> (cherry picked from commit 06f24fd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Aug 20, 2024
…383) (#387) * Use EuiCompressedFormRow * Use EuiCompressedField* * Use EuiCompressedSelect and EuiCompressedSuperSelect * Use EuiCompressedSwitch * Update snapshots --------- (cherry picked from commit 06f24fd) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace instances of
EuiButtonthat don't have an explicit sizing attribute toEuiSmallButton*.Replace instances of
Eui<form elements>that don't have density attributes toEuiCompressed<form elements>.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.