Update jest snapshots & cypress tests #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
requested review from
pjfitzgibbons,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
=======================================
Coverage ? 94.73%
=======================================
Files ? 5
Lines ? 152
Branches ? 45
=======================================
Hits ? 144
Misses ? 8
Partials ? 0 ☔ View full report in Codecov by Sentry. |
joshuali925
previously approved these changes
Jan 10, 2024
| DEFAULT_SIZE, | ||
| } from '../utils/constants'; | ||
| import customParseFormat from 'dayjs/plugin/customParseFormat'; | ||
| import dayjs from 'dayjs'; |
There was a problem hiding this comment.
are we moving to dayjs or just for testing?
There was a problem hiding this comment.
This is just for testing time formats. We had issues earlier when checking absolute time, hence moved to testing time format. FTR has this issue already fixed in.
mengweieric
previously approved these changes
Jan 10, 2024
YANG-DB
previously approved these changes
Jan 10, 2024
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
dismissed stale reviews from YANG-DB, mengweieric, and joshuali925
via
87162c7
mengweieric
approved these changes
Jan 10, 2024
joshuali925
approved these changes
Jan 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
* update visualizations cypress Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> * remove cypress delay and wait calls Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit d1551b7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Jan 11, 2024
* update visualizations cypress * update snapshots * remove cypress delay and wait calls --------- (cherry picked from commit d1551b7) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update jest snapshots & cypress tests
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.