fix: prevent overlay from overlapping new application header #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <[email protected]>
virajsanghvi
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
junqiu-lei
approved these changes
Oct 1, 2024
vamshin
approved these changes
Oct 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
(cherry picked from commit c043733)
junqiu-lei
pushed a commit
that referenced
this pull request
Oct 1, 2024
…681) (cherry picked from commit c043733) Co-authored-by: Viraj Sanghvi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the layers right pane was designed with the older header in mind, and pushed the page content to the left. The new page header isn't build for a static right pane, and because it is no longer fixed height, it is difficult to move the pushed flyout underneath it without things looking weird. Ideally, this flight was moved to become a panel, but to fix this bug in the short term, this just forces the flyout into overlay mode at the window width it starts creating problems.
Under this new breakpoint (1576, used to be 992), the experience looks like
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.