-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[navigation]feat: update category to flatten menus in analytics(all) use case #674
Merged
junqiu-lei
merged 2 commits into
opensearch-project:main
from
SuZhou-Joe:feature/category-change
Sep 30, 2024
Merged
[navigation]feat: update category to flatten menus in analytics(all) use case #674
junqiu-lei
merged 2 commits into
opensearch-project:main
from
SuZhou-Joe:feature/category-change
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
September 26, 2024 03:51
13 tasks
junqiu-lei
previously approved these changes
Sep 26, 2024
VijayanB
previously approved these changes
Sep 26, 2024
Please add changelog |
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
dismissed stale reviews from VijayanB and junqiu-lei
via
September 29, 2024 06:28
be8646e
Updated |
Can we add backport 2.x label for this PR? |
junqiu-lei
approved these changes
Sep 30, 2024
VijayanB
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…use case (#674) * feat: update category Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 4fd51cc)
junqiu-lei
pushed a commit
that referenced
this pull request
Oct 1, 2024
…use case (#674) (#679) * feat: update category Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 4fd51cc) Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on opensearch-project/OpenSearch-Dashboards#8332, maps needs to make some adjustment to flatten the menus in analytics(all) use case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.