Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed workflow detail page UX bugs #457

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fixed workflow detail page UX bugs #457

merged 1 commit into from
Oct 31, 2024

Conversation

saimedhi
Copy link
Collaborator

Description

  • Reduced padding between panels
  • Added border radius to the panels
  • Decreased empty space at the bottom below panels.
  • Fixed header as previous workflow title is some part cut at the top.
  • Removed unwanted margins present for panels in workflow detail page
screen-capture.25.webm

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi
Copy link
Collaborator Author

  • @ohltyler, please take a look.
  • @kamingleung, please take a look at the screen recorder above and track any more bugs observed in the UX for both Old and New look. Thank you.

@saimedhi saimedhi marked this pull request as ready for review October 31, 2024 06:34
@saimedhi
Copy link
Collaborator Author

Failing test will be fixed with opensearch-project/opensearch-dashboards-functional-test#1612

@ohltyler
Copy link
Member

@saimedhi this is great! One question, I see the overall margins on the edge of the window is different on the workflow list and the workflow details page - should these be consistent?

screen-capture.13.webm

@saimedhi
Copy link
Collaborator Author

@saimedhi this is great! One question, I see the overall margins on the edge of the window is different on the workflow list and the workflow details page - should these be consistent?

screen-capture.13.webm

Yes, Tyler I notice that too. But in workflow detail Page, UX team suggested to have Same Appearance as discover page.(less padding around panels). I will reconnect with UX today and show both New Look and Old look and request them to track if any further changes needed.

ohltyler
ohltyler approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to merge, but please track the remaining spacing issues and confirm with UX that the above is acceptable.

@saimedhi saimedhi merged commit dc07e49 into opensearch-project:main Oct 31, 2024
8 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 31, 2024
@github-actions
Fixed workflow detail page UX bugs (#457)
45c937b 
Signed-off-by: saimedhi <[email protected]>
(cherry picked from commit dc07e49)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 31, 2024
Merged
saimedhi pushed a commit that referenced this pull request Oct 31, 2024
@opensearch-trigger-bot @github-actions
Fixed workflow detail page UX bugs (#457) (#458)
11da61a 
(cherry picked from commit dc07e49)

Signed-off-by: saimedhi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kamingleung
Copy link

@ohltyler The visual designer is considered a "full-screen" application, similar to Discover. Therefore, UX would recommend follow the same spacing pattern as the new Discover to maximize workable space.

@kamingleung
Copy link

@saimedhi
image
Looks like the Preview and Inspector panels have width padding inside the panels. Can you make sure they are consistent with the left panel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohltyler ohltyler ohltyler approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saimedhi @ohltyler @kamingleung