Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add rule validation in AnomalyDetector constructor #1342

Merged
merged 1 commit into from
Oct 18, 2024

Add rule validation in AnomalyDetector constructor (#1341)

f9964ac
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] Add rule validation in AnomalyDetector constructor #1342

Add rule validation in AnomalyDetector constructor (#1341)
f9964ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 1s

80.06% (+0.17%) compared to d6758c6

View this Pull Request on Codecov

80.06% (+0.17%) compared to d6758c6

Details

Codecov Report

Attention: Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.06%. Comparing base (d6758c6) to head (f9964ac).

Files with missing lines Patch % Lines
.../java/org/opensearch/ad/model/AnomalyDetector.java 95.91% 0 Missing and 2 partials ⚠️
...imeseries/transport/SuggestConfigParamRequest.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1342      +/-   ##
============================================
+ Coverage     79.89%   80.06%   +0.17%     
- Complexity     5654     5674      +20     
============================================
  Files           533      533              
  Lines         23411    23430      +19     
  Branches       2323     2335      +12     
============================================
+ Hits          18704    18760      +56     
+ Misses         3608     3562      -46     
- Partials       1099     1108       +9     
Files with missing lines Coverage Δ
...main/java/org/opensearch/ad/ml/ADModelManager.java 79.25% <ø> (+3.15%) ⬆️
...ch/timeseries/ml/MemoryAwareConcurrentHashmap.java 84.61% <ø> (+53.18%) ⬆️
...ensearch/timeseries/model/ValidationIssueType.java 100.00% <100.00%> (ø)
...imeseries/transport/SuggestConfigParamRequest.java 92.59% <75.00%> (+54.13%) ⬆️
.../java/org/opensearch/ad/model/AnomalyDetector.java 88.99% <95.91%> (+2.65%) ⬆️

... and 13 files with indirect coverage changes