Add custom result index lifecycle management condition fields to config #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
kaituo
reviewed
May 31, 2024
Signed-off-by: Jackie Han <[email protected]>
kaituo
reviewed
May 31, 2024
| @@ -268,14 +277,23 @@ public AnomalyDetector(StreamInput input) throws IOException { | |||
| if (input.readBoolean()) { | |||
| this.rules = input.readList(Rule::new); | |||
| } | |||
| if (input.readBoolean()) { | |||
There was a problem hiding this comment.
You can use readOptionalInt now.
There was a problem hiding this comment.
good catch! forgot to update this part
| @@ -294,6 +306,21 @@ public Config(StreamInput input) throws IOException { | |||
| this.recencyEmphasis = input.readInt(); | |||
| this.seasonIntervals = input.readInt(); | |||
| this.historyIntervals = input.readInt(); | |||
| if (input.readBoolean()) { | |||
There was a problem hiding this comment.
You can use readOptionalInt now.
Signed-off-by: Jackie Han <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
============================================
- Coverage 80.39% 71.69% -8.70%
- Complexity 4589 4844 +255
============================================
Files 336 517 +181
Lines 19118 22731 +3613
Branches 1993 2248 +255
============================================
+ Hits 15369 16296 +927
- Misses 2796 5407 +2611
- Partials 953 1028 +75
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
previously approved these changes
May 31, 2024
Signed-off-by: Jackie Han <[email protected]>
kaituo
approved these changes
Jun 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
…ig (#1215) * Add custom result index lifecycle management condition fields to config Signed-off-by: Jackie Han <[email protected]> * add more tests Signed-off-by: Jackie Han <[email protected]> * utilizing readOptionalInt() method when reading nullable value Signed-off-by: Jackie Han <[email protected]> * add more tests Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit 05b04b9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jackiehanyang
pushed a commit
that referenced
this pull request
Jun 4, 2024
…ig (#1215) (#1216) * Add custom result index lifecycle management condition fields to config * add more tests * utilizing readOptionalInt() method when reading nullable value * add more tests --------- (cherry picked from commit 05b04b9) Signed-off-by: Jackie Han <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add custom result index lifecycle management condition fields to config
Issues Resolved
#1213
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.