Skip to content

Address code review comments

Codecov / codecov/patch succeeded Mar 27, 2024 in 1s

80.00% of diff hit (target 71.42%)

View this Pull Request on Codecov

80.00% of diff hit (target 71.42%)

Annotations

Check warning on line 118 in modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java#L118

Added line #L118 was not covered by tests

Check warning on line 133 in modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java#L133

Added line #L133 was not covered by tests

Check warning on line 221 in modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java#L221

Added line #L221 was not covered by tests

Check warning on line 191 in server/src/main/java/org/opensearch/common/network/NetworkModule.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/common/network/NetworkModule.java#L191

Added line #L191 was not covered by tests

Check warning on line 36 in server/src/main/java/org/opensearch/plugins/SecureTransportSettingsProvider.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/plugins/SecureTransportSettingsProvider.java#L36

Added line #L36 was not covered by tests