-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Streaming Indexing] Introduce new experimental HTTP transport based on Netty 4 and Project Reactor (Reactor Netty) #9672
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change c0755f4 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git] |
Compatibility status:Checks if related components are compatible with change 404a9d5 Incompatible componentsSkipped componentsCompatible components |
Compatibility status:Checks if related components are compatible with change 2645c08 Incompatible componentsSkipped componentsCompatible components |
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change a91fef9 Incompatible componentsSkipped componentsCompatible components |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 87f5ed7 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/ml-commons.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
20d9596
to
af94d0e
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9672 +/- ##
============================================
+ Coverage 71.20% 71.27% +0.06%
- Complexity 58716 58834 +118
============================================
Files 4872 4883 +11
Lines 276773 277134 +361
Branches 40240 40284 +44
============================================
+ Hits 197078 197520 +442
+ Misses 63238 63121 -117
- Partials 16457 16493 +36
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
… based on Netty 4 and Project Reactor (Reactor Netty) Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Seeing no feedback for a few weeks, merging the change |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9672-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1782b906a0a9bf293bbc8e7f33058153790827dc
# Push it to GitHub
git push --set-upstream origin backport/backport-9672-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…on Netty 4 and Project Reactor (Reactor Netty) (opensearch-project#9672) * [Streaming Indexing] Introduce new experimental server HTTP transport based on Netty 4 and Project Reactor (Reactor Netty) Signed-off-by: Andriy Redko <[email protected]> * Remove HttpChunk for now since it is not used in non-streaming APIs Signed-off-by: Andriy Redko <[email protected]> * Fix postmerge issues Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 1782b90)
…on Netty 4 and Project Reactor (Reactor Netty) (opensearch-project#9672) * [Streaming Indexing] Introduce new experimental server HTTP transport based on Netty 4 and Project Reactor (Reactor Netty) Signed-off-by: Andriy Redko <[email protected]> * Remove HttpChunk for now since it is not used in non-streaming APIs Signed-off-by: Andriy Redko <[email protected]> * Fix postmerge issues Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 1782b90) Signed-off-by: Andriy Redko <[email protected]>
…on Netty 4 and Project Reactor (Reactor Netty) (opensearch-project#9672) * [Streaming Indexing] Introduce new experimental server HTTP transport based on Netty 4 and Project Reactor (Reactor Netty) Signed-off-by: Andriy Redko <[email protected]> * Remove HttpChunk for now since it is not used in non-streaming APIs Signed-off-by: Andriy Redko <[email protected]> * Fix postmerge issues Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 1782b90) Signed-off-by: Andriy Redko <[email protected]>
…on Netty 4 and Project Reactor (Reactor Netty) (opensearch-project#9672) * [Streaming Indexing] Introduce new experimental server HTTP transport based on Netty 4 and Project Reactor (Reactor Netty) Signed-off-by: Andriy Redko <[email protected]> * Remove HttpChunk for now since it is not used in non-streaming APIs Signed-off-by: Andriy Redko <[email protected]> * Fix postmerge issues Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 1782b90) Signed-off-by: Andriy Redko <[email protected]>
…on Netty 4 and Project Reactor (Reactor Netty) (#9672) (#11108) * [Streaming Indexing] Introduce new experimental server HTTP transport based on Netty 4 and Project Reactor (Reactor Netty) * Remove HttpChunk for now since it is not used in non-streaming APIs * Fix postmerge issues --------- (cherry picked from commit 1782b90) Signed-off-by: Andriy Redko <[email protected]>
…on Netty 4 and Project Reactor (Reactor Netty) (opensearch-project#9672) * [Streaming Indexing] Introduce new experimental server HTTP transport based on Netty 4 and Project Reactor (Reactor Netty) Signed-off-by: Andriy Redko <[email protected]> * Remove HttpChunk for now since it is not used in non-streaming APIs Signed-off-by: Andriy Redko <[email protected]> * Fix postmerge issues Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]>
…on Netty 4 and Project Reactor (Reactor Netty) (opensearch-project#9672) * [Streaming Indexing] Introduce new experimental server HTTP transport based on Netty 4 and Project Reactor (Reactor Netty) Signed-off-by: Andriy Redko <[email protected]> * Remove HttpChunk for now since it is not used in non-streaming APIs Signed-off-by: Andriy Redko <[email protected]> * Fix postmerge issues Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
As have been concluded in #7273, introducing new transport based on Project Reactor would let us to:
Introducing new experimental HTTP transport based on Netty 4 and Project Reactor (Reactor Netty).
Related Issues
Closes #9067
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.