-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Removing version checks from RemoteSegmentStats #9545
Merged
Bukhtawar
merged 2 commits into
opensearch-project:main
from
shourya035:rs-stats-version-check
Aug 25, 2023
Merged
[Remote Store] Removing version checks from RemoteSegmentStats #9545
Bukhtawar
merged 2 commits into
opensearch-project:main
from
shourya035:rs-stats-version-check
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shourya Dutta Biswas <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Shourya Dutta Biswas <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
shourya035
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale,
sohami and
msfroh
as code owners
August 25, 2023 11:00
Codecov Report
@@ Coverage Diff @@
## main #9545 +/- ##
============================================
- Coverage 71.15% 71.06% -0.10%
+ Complexity 57485 57435 -50
============================================
Files 4778 4778
Lines 270981 270979 -2
Branches 39585 39583 -2
============================================
- Hits 192823 192577 -246
- Misses 61941 62199 +258
+ Partials 16217 16203 -14
|
Bukhtawar
reviewed
Aug 25, 2023
server/src/main/java/org/opensearch/index/remote/RemoteSegmentStats.java
Show resolved
Hide resolved
Bukhtawar
approved these changes
Aug 25, 2023
Gaganjuneja
pushed a commit
to Gaganjuneja/OpenSearch
that referenced
this pull request
Aug 28, 2023
…earch-project#9545) * Removing version checks Signed-off-by: Shourya Dutta Biswas <[email protected]>
Gaganjuneja
pushed a commit
to Gaganjuneja/OpenSearch
that referenced
this pull request
Aug 28, 2023
…earch-project#9545) * Removing version checks Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Gagan Juneja <[email protected]>
kkmr
pushed a commit
to kkmr/OpenSearch
that referenced
this pull request
Aug 28, 2023
…earch-project#9545) * Removing version checks Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kiran Reddy <[email protected]>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…earch-project#9545) * Removing version checks Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
…earch-project#9545) * Removing version checks Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…earch-project#9545) * Removing version checks Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing version checks from
RemoteSegmentStats
to retain BwC. This PR should be followed after #9544 is mergedCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.