Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Segment Replication][Remote Store] Remove commits when remote store is enabled #8753

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2f830be from #8050.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/20446/

* **CommitID:** [16bf425](https://github.com/opensearch-project/OpenSearch/commit/16bf425fe3e17de851c17b83443dda6a46d8b120)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

#8030

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…is enabled (#8050)

* remove commits + fix failing test

Signed-off-by: Poojita Raj <[email protected]>

* fix failing tests

Signed-off-by: Poojita Raj <[email protected]>

* fix precommit failure

Signed-off-by: Poojita Raj <[email protected]>

* remove logs

Signed-off-by: Poojita Raj <[email protected]>

* address review comments

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
(cherry picked from commit 2f830be)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mch2 mch2 force-pushed the backport/backport-8050-to-2.x branch from 16bf425 to bd6f387 Compare July 26, 2023 18:15
@mch2 mch2 requested a review from sohami as a code owner July 26, 2023 18:15
@mch2
Copy link
Member

mch2 commented Jul 26, 2023

Pushed a rebase here - we need to get this missing backport in that was blocked by other segrep flaky tests that should now either be fixed or muted.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/21002/

* **CommitID:** [16bf425](https://github.com/opensearch-project/OpenSearch/commit/16bf425fe3e17de851c17b83443dda6a46d8b120)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

Still waiting to schedule task - seems like gradle check never ran

@mch2
Copy link
Member

mch2 commented Jul 26, 2023

@Poojita-Raj That one is on me - I had manually triggered a re-run before pushing the rebase. So the first run is cancelled.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadBlobWithRetries
      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartFileCorruptionIT.testLocalFileCorruptionDuringUpload

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #8753 (bd6f387) into 2.x (4c131e6) will decrease coverage by 0.03%.
Report is 2 commits behind head on 2.x.
The diff coverage is 68.00%.

@@             Coverage Diff              @@
##                2.x    #8753      +/-   ##
============================================
- Coverage     70.83%   70.81%   -0.03%     
- Complexity    57361    57392      +31     
============================================
  Files          4745     4745              
  Lines        271057   271064       +7     
  Branches      39977    39980       +3     
============================================
- Hits         192004   191943      -61     
- Misses        62575    62635      +60     
- Partials      16478    16486       +8     
Files Changed Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java 69.28% <42.85%> (+0.12%) ⬆️
.../opensearch/index/engine/NRTReplicationEngine.java 76.66% <100.00%> (+0.80%) ⬆️

... and 441 files with indirect coverage changes

@mch2 mch2 merged commit 23ddab2 into 2.x Jul 26, 2023
@mch2 mch2 deleted the backport/backport-8050-to-2.x branch July 26, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants