Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fail open stats in case the only healthy shard copy reside in weighed away az #7600

Conversation

anshu1106
Copy link
Contributor

Description

This PR fixes fail open stats in case the only healthy shard copy reside in weighed away az data nodes

Related Issues

Resolves #7599

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@anshu1106 anshu1106 changed the title Fix Fail open stats in case the only healthy shard copy reside in weighed away az Fix fail open stats in case the only healthy shard copy reside in weighed away az May 17, 2023
@anshu1106 anshu1106 force-pushed the fail-open-stats-one-healthy-copy branch from ff721ac to 2f010af Compare May 17, 2023 09:05
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented May 23, 2023

Let's get this to green?

@anshu1106 anshu1106 force-pushed the fail-open-stats-one-healthy-copy branch from 2f010af to fbff9f3 Compare May 24, 2023 07:05
@anshu1106 anshu1106 requested a review from dbwiddis as a code owner May 24, 2023 07:05
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@anshu1106 anshu1106 changed the base branch from main to 2.x May 24, 2023 09:57
Signed-off-by: Anshu Agarwal <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Anshu Agarwal <[email protected]>
@anshu1106 anshu1106 force-pushed the fail-open-stats-one-healthy-copy branch from 1d9d962 to 29c12ce Compare May 27, 2023 04:54
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Anshu Agarwal <[email protected]>
@anshu1106 anshu1106 force-pushed the fail-open-stats-one-healthy-copy branch from 628a7fe to 78c4d03 Compare May 27, 2023 16:49
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

@anshu1106
Copy link
Contributor Author

Let's get this to green?

addressed

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jun 27, 2023
@opensearch-trigger-bot
Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

@kotwanikunal
Copy link
Member

Apologies. This PR was auto closed without reaching a resolution from the maintainers.
Re-opening to move it forward.
Thanks for your contributions to OpenSearch!

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 78c4d03

Incompatible components

Skipped components

Compatible components

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94
Copy link
Member

@anshu1106 Is this being worked upon? You can tag the maintainers to get traction on this.

@ticheng-aws
Copy link
Contributor

Hi @anshu1106, do we have any updates?

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 14, 2024
@kotwanikunal
Copy link
Member

Closing this PR due to inactivity. @anshu1106 Please re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Weighted Shard Routing] Fail open count is not updated for only healthy copy in weighed away az
5 participants