Adds ExtensionsManager.lookupExtensionSettingsById

[cwperks]

Description

Companion PR in the security plugin: opensearch-project/security#2749

Adds a public method to lookup extension settings placed in extensions.yml by the extension unique id. There was a recent issue with extension handshake and the security plugin where the only available method exposed looks up initialized extensions which is not populated at the time of initial handshake: opensearch-project/security#2747

This new method is utilized in the security plugin to ensure that the unique id exists in extensions.yml so that it can permit the transport requests that an extension uses to bootstrap

Related Issues

Resolves opensearch-project/security#2747

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/15061/
• CommitID: f188c34

[codecov-commenter]

Codecov Report

Merging #7466 (00f3ece) into main (6ac3317) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##               main    #7466      +/-   ##
============================================
- Coverage     70.55%   70.51%   -0.05%     
- Complexity    59666    59684      +18     
============================================
  Files          4887     4887              
  Lines        286559   286562       +3     
  Branches      41307    41307              
============================================
- Hits         202193   202057     -136     
- Misses        67727    67878     +151     
+ Partials      16639    16627      -12     

Impacted Files	Coverage Δ
...a/org/opensearch/extensions/ExtensionsManager.java	47.87% <100.00%> (+0.61%)	⬆️

... and 479 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.discovery.StableClusterManagerDisruptionIT.testStaleClusterManagerNotHijackingMajority
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

• URL: https://build.ci.opensearch.org/job/gradle-check/15062/
• CommitID: 140440d
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/15112/
• CommitID: 48264c2
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationIT.testReplicationPostDeleteAndForceMerge

• URL: https://build.ci.opensearch.org/job/gradle-check/15114/
• CommitID: 00f3ece
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[peternied]

@cwperks Could you please investigate the test failure to see if this is a flaky test?

org.opensearch.indices.replication.SegmentReplicationIT.testReplicationPostDeleteAndForceMerge

[cwperks]

@peternied This test showed up with flaky test finder according to this comment: #6761 (comment)

[DarshitChanpura]

Nicely done. This will fix the TLS setup issue with extensions!

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7466-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16555e42ca5a0058133f2769a617a1e6ef200c27
# Push it to GitHub
git push --set-upstream origin backport/backport-7466-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7466-to-2.x.

[cwperks]

I'll open a manual backport for this