-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] changed version from 3.0.0 to version.current in extensionManagerTest #7176
[Extensions] changed version from 3.0.0 to version.current in extensionManagerTest #7176
Conversation
…s.java Signed-off-by: varuntumbe <[email protected]>
bb8b25d
to
c76f700
Compare
Hi @owaiskazi19 , I have changed the opensearchVersion and minimumCompatibleVersion but have not modified version of dependency as it has not been modifed in 2.x, If you want that I can modify that as well. Thanks and Regards |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7176 +/- ##
============================================
+ Coverage 70.67% 70.81% +0.13%
- Complexity 59457 59528 +71
============================================
Files 4852 4848 -4
Lines 285189 285158 -31
Branches 41118 41111 -7
============================================
+ Hits 201564 201930 +366
+ Misses 67042 66640 -402
- Partials 16583 16588 +5
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we merge, don't we want a range here?
" opensearchVersion: '3.0.0'", | ||
" minimumCompatibleVersion: '3.0.0'", | ||
" opensearchVersion: '" + Version.CURRENT.toString() + "'", | ||
" minimumCompatibleVersion: '" + Version.CURRENT.toString() + "'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for tests we want to use the minimum as the major.0.0, otherwise this perpetuates the idea that the extension is narrowly compatible with the current version only, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dblock ,
Are you saying that we should we have different version like 2.0.0 for first extension and 3.0.0 or 4.0.0 for second extension and so on ? meaning tests has to pass for extensions of all version otherwise we are saying tests are compatible for only the current versions and not the ones before ?
Thanks and Regards
Varun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. Have predictable examples plus one for current version.
This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Apologies. This PR was auto closed without reaching a resolution from the maintainers. |
Compatibility status:Checks if related components are compatible with change c76f700 Incompatible componentsSkipped componentsCompatible components |
Gradle Check (Jenkins) Run Completed with:
|
@varuntumbe - Do you think if you will be coming up with a revision on this? If not, please close it. |
…s.java
Description
changed version from 3.0.0 to version.current in extensionManagerTest
Issues Resolved
#7051
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.