Display phase name in stash dump of a test failure.

[dblock]

Signed-off-by: dblock [email protected]

Description

Looking at failures in #5219 it's not immediately obvious whether the failure is in setup/execution/teardown. You can deduce it from the above lines, but it doesn't cost much to display it inline with the dump.

Leaving this as draft, should trigger enough gradle failures to see it be useful/not.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/6824/
• CommitID: edf11df
  Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/6857/
• CommitID: 5d5f485

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/6865/
• CommitID: 5d5f485

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/6874/
• CommitID: c412a11

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/6917/
• CommitID: 641293b
  Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[dblock]

I'm just waiting for those S3 YAML tests to fail :) too lazy to write a long loop

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/6962/
• CommitID: 07ba39a

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/6974/
• CommitID: 87e4605

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/6995/
• CommitID: 626c053

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• FAILURES:

• URL: https://build.ci.opensearch.org/job/gradle-check/7006/
• CommitID: 11e97c2
  Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7031/
• CommitID: 4915f57

[codecov-commenter]

Codecov Report

Merging #5223 (4915f57) into main (7aa615f) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #5223      +/-   ##
============================================
+ Coverage     71.02%   71.04%   +0.01%     
+ Complexity    58161    58156       -5     
============================================
  Files          4704     4704              
  Lines        277401   277401              
  Branches      40166    40166              
============================================
+ Hits         197025   197071      +46     
+ Misses        64204    64154      -50     
- Partials      16172    16176       +4     

Impacted Files	Coverage Δ
...t/rest/yaml/OpenSearchClientYamlSuiteTestCase.java	10.05% <0.00%> (ø)
...pensearch/client/cluster/RemoteConnectionInfo.java	0.00% <0.00%> (-68.30%)	⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java	0.00% <0.00%> (-52.95%)	⬇️
...ava/org/opensearch/action/NoSuchNodeException.java	0.00% <0.00%> (-50.00%)	⬇️
.../opensearch/client/cluster/RemoteInfoResponse.java	61.53% <0.00%> (-38.47%)	⬇️
...org/opensearch/test/engine/MockInternalEngine.java	47.82% <0.00%> (-34.79%)	⬇️
...opensearch/snapshots/SnapshotMissingException.java	28.57% <0.00%> (-28.58%)	⬇️
...rc/main/java/org/opensearch/ingest/IngestInfo.java	51.72% <0.00%> (-27.59%)	⬇️
...earch/client/indices/GetIndexTemplatesRequest.java	50.00% <0.00%> (-23.08%)	⬇️
...adcast/BroadcastShardOperationFailedException.java	55.55% <0.00%> (-22.23%)	⬇️
... and 451 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dblock]

@reta I believe you've looked at the flaky yaml/REST tests, this might be useful. I'll close it for now.