-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Adding PrimaryMode check before publishing checkpoint and processing a received checkpoint. #4157
Merged
Rishikesh1159
merged 10 commits into
opensearch-project:main
from
Rishikesh1159:segrep/checkpointPublish-PrimaryMode
Aug 15, 2022
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e0dcca6
Adding PrimaryMode check before publishing checkpoint.
Rishikesh1159 c048700
Applying spotless check
Rishikesh1159 31db9c7
Moving segrep specific tests to SegmentReplicationIndexShardTests.
Rishikesh1159 a7dfbb8
Adding logic and tests for rejecting checkpoints if shard is in Prima…
Rishikesh1159 fde5a61
Merge branch 'main' into segrep/checkpointPublish-PrimaryMode
Rishikesh1159 9f2be06
Applying ./gradlew :server:spotlessApply.
Rishikesh1159 7519ba7
Merge branch 'segrep/checkpointPublish-PrimaryMode' of https://github…
Rishikesh1159 226f1c0
Applying ./gradlew :server:spotlessApply
Rishikesh1159 66fbfcb
Changing log level to warn in shouldProcessCheckpoint() of IndexShard…
Rishikesh1159 4989d2b
Removing unnecessary lazy logging in shouldProcessCheckpoint().
Rishikesh1159 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also reject checkpoints if the replica copy(where the checkpoint was sent to) is operating in primary mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also on that note - we will want to cancel any ongoing replication events on both sides. I've added #4136 to cover this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it also worth checking shardRouting here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Logic to reject checkpoints if shard is in PrimaryMode in latest commit.