Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LegacyESVersion.V_6_8_x constants #1869

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Remove LegacyESVersion.V_6_8_x constants #1869

merged 1 commit into from
Jan 10, 2022

Conversation

adnapibar
Copy link
Contributor

Description

This commit removes all usages of the LegacyESVersion.V_6_8_x constants from the codebase.

Issues Resolved

Part of #1674

Check List

  • All tests pass
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda [email protected]

@adnapibar adnapibar added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues labels Jan 7, 2022
@adnapibar adnapibar requested a review from a team as a code owner January 7, 2022 21:11
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

adnapibar
adnapibar commented Jan 7, 2022
View reviewed changes
server/src/test/java/org/opensearch/common/rounding/RoundingDuelTests.java
@@ -48,31 +45,6 @@
// dont include nano/micro seconds as rounding would become zero then and throw an exception
private static final String[] ALLOWED_TIME_SUFFIXES = new String[] { "d", "h", "ms", "s", "m" };

public void testSerialization() throws Exception {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rounding logic for Joda has been deprecated and currently only exists in tests. We can clean these up in another PR. Just removing this test for build to pass.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f5c41fbf2641c073394d8087f6df3b6aeb2fdc38
Log 1809

Reports 1809

@adnapibar
Copy link
Contributor Author

❌   Gradle Check failure f5c41fb Log 1809

Reports 1809

Test Failure non reproducible, ongoing issue with test failures in CI

@adnapibar
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f5c41fbf2641c073394d8087f6df3b6aeb2fdc38
Log 1811

Reports 1811

@adnapibar
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f5c41fbf2641c073394d8087f6df3b6aeb2fdc38
Log 1812

Reports 1812

@adnapibar
Remove LegacyESVersion.V_6_8_x constants
8a0798d 
This commit removes all usages of the `LegacyESVersion.V_6_8_x` constants from the codebase.

Signed-off-by: Rabi Panda <[email protected]>
@adnapibar adnapibar mentioned this pull request Jan 8, 2022
Closed
19 tasks
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 8a0798d
Log 1816

Reports 1816

nknize
nknize approved these changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nknize nknize merged commit 52508d5 into opensearch-project:main Jan 10, 2022
@reta
Copy link
Collaborator

reta commented Jan 10, 2022

@adnapibar rebased against latest master and seeing this test failure:

  2> REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.coordination.JoinTaskExecutorTests.testPreventJoinClusterWithUnsupportedNodeVersions" -Dtests.seed=AC65353F5EEC13BD -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en-SG -Dtests.timezone=America/Cayman -Druntime.java=17
  2> java.lang.IllegalArgumentException: minVersion [6.8.0] does not exist.
        at __randomizedtesting.SeedInfo.seed([AC65353F5EEC13BD:2F1A92458C2F83F1]:0)
        at org.opensearch.test.VersionUtils.randomVersionBetween(VersionUtils.java:305)
        at org.opensearch.cluster.coordination.JoinTaskExecutorTests.testPreventJoinClusterWithUnsupportedNodeVersions(JoinTaskExecutorTests.java:128)

Coming from #1866, the log file is there https://ci.opensearch.org/logs/ci/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/gradle_check_1837.log

@reta reta mentioned this pull request Jan 10, 2022
Merged
5 tasks
@adnapibar
Copy link
Contributor Author

./gradlew ':server:test' --tests "org.opensearch.cluster.coordination.JoinTaskExecutorTests.testPreventJoinClusterWithUnsupportedNodeVersions" -Dtests.seed=AC65353F5EEC13BD -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en-SG -Dtests.timezone=America/Cayman -Druntime.java=17

Thanks @reta - looking into it

@adnapibar adnapibar deleted the remove-v6.8.x branch November 15, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adnapibar @opensearch-ci-bot @reta @nknize