[TEST] Fix FsHealthServiceTest by increasing the timeout period before checking the FS health after restoring the FS status #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e checking the FS health after restoring the FS status Signed-off-by: Tianli Feng <[email protected]>
|
Can one of the admins verify this patch? |
andrross
approved these changes
Dec 28, 2021
tlfeng
added
the
pending backport
|
Update: The test fix has been included in the commit 88d1d65 of the PR #1269, by Bukhtawar in #1692 (comment). |
tlfeng
removed
the
pending backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although there has been a commit baa10b9 that aimed to fix the test failure in #1567, there is still a failure reported in #1567 (comment).
The PR gives another try to fix the unit test
testFailsHealthOnHungIOBeyondHealthyTimeout()in classFsHealthServiceTestsby extending the timeout period again, based on the idea in #1567 (comment).3xmultiplier to4xthat applied torefreshInterval.For more detail about the past attempt to fix the test, please see PR #1692
Issues Resolved
Fix #1567
#1307 and #1450 - These 2 issues reporting the same test failure as #1567.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.