Remove LegacyESVersion.V_6_4_x constants

[adnapibar]

Description

This PR removes LegacyESVersion.V_6_4_x constants.

Issues Resolved

Part of the meta issue #1674

Check List

• All tests pass
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda [email protected]

[opensearch-ci-bot]

Can one of the admins verify this patch?

[opensearch-ci-bot]

✅   Gradle Check success 8cb36d9c0ce232dc65b58b09b8636a019e0c59ab
Log 1619

Reports 1619

[opensearch-ci-bot]

❌   Gradle Check failure 5104fcf7e60b1645f01d706d2355c53f89edfc8e
Log 1631

Reports 1631

[adnapibar]

Unrelated & un-reproducible failure

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.stats.IndexStatsIT.testFilterCacheStats" -Dtests.seed=80C55F59F84BA870 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-MA -Dtests.timezone=US/Pacific -Druntime.java=17

org.opensearch.indices.stats.IndexStatsIT > testFilterCacheStats FAILED
    java.lang.AssertionError: shard [index][1] on node [node_s0] has pending operations:
     --> RetentionLeaseBackgroundSyncAction.Request{retentionLeases=RetentionLeases{primaryTerm=1, version=397, leases={peer_recovery/yxVn6WJyS-aXPxJftRrXqQ=RetentionLease{id='peer_recovery/yxVn6WJyS-aXPxJftRrXqQ', retainingSequenceNumber=2, timestamp=1640208027646, source='peer recovery'}}}, shardId=[index][1], timeout=1m, index='index', waitForActiveShards=0}
    	at org.opensearch.index.shard.IndexShardOperationPermits.acquire(IndexShardOperationPermits.java:248)
    	at org.opensearch.index.shard.IndexShard.acquirePrimaryOperationPermit(IndexShard.java:3231)
    	at org.opensearch.action.support.replication.TransportReplicationAction.acquirePrimaryOperationPermit(TransportReplicationAction.java:1117)
    	at org.opensearch.action.support.replication.TransportReplicationAction$AsyncPrimaryAction.doRun(TransportReplicationAction.java:434)
    	at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:50)
    	at org.opensearch.action.support.replication.TransportReplicationAction.handlePrimaryRequest(TransportReplicationAction.java:378)
    	at org.opensearch.transport.RequestHandlerRegistry.processMessageReceived(RequestHandlerRegistry.java:98)
    	at org.opensearch.transport.TransportService$8.doRun(TransportService.java:944)
    	at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:792)
    	at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:50)
    	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)

[adnapibar]

start gradle check

[opensearch-ci-bot]

❌   Gradle Check failure 5104fcf7e60b1645f01d706d2355c53f89edfc8e
Log 1632

Reports 1632

[adnapibar]

More flakiness

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=2D4D59BC490DD2BB -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-CS -Dtests.timezone=Etc/GMT+8 -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([2D4D59BC490DD2BB:2A3B8C77728BA4E6]:0)
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertTrue(Assert.java:52)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

[adnapibar]

start gradle check

[opensearch-ci-bot]

❌   Gradle Check failure 5104fcf7e60b1645f01d706d2355c53f89edfc8e
Log 1634

Reports 1634

[opensearch-ci-bot]

❌   Gradle Check failure 743b657ce3b9ad891a4a18b2769b4a16f889199d
Log 1637

Reports 1637

[adnapibar]

* What went wrong:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.
> Building 1.2.3 didn't generate expected file /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/distribution/bwc/bugfix/build/bwc/checkout-1.2/distribution/archives/linux-tar/build/distributions/opensearch-min-1.2.3-SNAPSHOT-linux-x64.tar.gz

[opensearch-ci-bot]

✅   Gradle Check success 3189f09
Log 1652

Reports 1652